From a78388508c91a82a037efe39f69b3f7d0d8713c5 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Tue, 27 Feb 2024 09:58:05 -0700 Subject: mb/system76/adl: Remove duplicate PchHdaAudioLinkHdaEnable This UPD is hooked up in devicetree since commit 854bd492fcfa ("mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree"). As these boards were in development when the change happened, they still had the UPD set via romstage. Remove them now so they are only set in devicetree. Change-Id: I393e2c7b0134a31feae20f8992d7fd447ff7ee59 Signed-off-by: Tim Crawford Reviewed-on: https://review.coreboot.org/c/coreboot/+/80755 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Jeremy Soller --- src/mainboard/system76/adl/variants/lemp11/romstage.c | 1 - src/mainboard/system76/adl/variants/oryp10/romstage.c | 1 - src/mainboard/system76/adl/variants/oryp9/romstage.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mainboard/system76/adl/variants/lemp11/romstage.c b/src/mainboard/system76/adl/variants/lemp11/romstage.c index 989b5dff8f..211ab97d20 100644 --- a/src/mainboard/system76/adl/variants/lemp11/romstage.c +++ b/src/mainboard/system76/adl/variants/lemp11/romstage.c @@ -15,7 +15,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) }; const bool half_populated = false; - mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0; diff --git a/src/mainboard/system76/adl/variants/oryp10/romstage.c b/src/mainboard/system76/adl/variants/oryp10/romstage.c index 48714e0c85..86ecf32826 100644 --- a/src/mainboard/system76/adl/variants/oryp10/romstage.c +++ b/src/mainboard/system76/adl/variants/oryp10/romstage.c @@ -23,7 +23,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) // Set primary display to internal graphics mupd->FspmConfig.PrimaryDisplay = 0; - mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0; diff --git a/src/mainboard/system76/adl/variants/oryp9/romstage.c b/src/mainboard/system76/adl/variants/oryp9/romstage.c index d16b4f8b03..5e6cf7dd52 100644 --- a/src/mainboard/system76/adl/variants/oryp9/romstage.c +++ b/src/mainboard/system76/adl/variants/oryp9/romstage.c @@ -20,7 +20,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) // Set primary display to internal graphics mupd->FspmConfig.PrimaryDisplay = 0; - mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0; -- cgit v1.2.3