From a296ce75e304dcf163a770e3dc6ca580b7a61d29 Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Fri, 31 May 2013 19:36:52 +0200 Subject: Move the MARK_GRAPHICS_MEM_WRCOMB to x86 architecture The MARK_GRAPHICS_MEM_WRCOMB was spreading like a cancer since it was defined in sandybridge. It is really more of an x86 thing however, and we now have three systems that can use it. I considered making this more general, since it technically can apply to PTE-based systems like ARM, and maybe we should. But the 'WRCOMB' moniker is usually closely tied to the x86. Change-Id: I3eb6eb2113843643348a5e18e78c53d113899ff8 Signed-off-by: Ronald G. Minnich Reviewed-on: http://review.coreboot.org/3349 Tested-by: build bot (Jenkins) --- src/arch/x86/Kconfig | 8 ++++++++ src/northbridge/intel/haswell/Kconfig | 8 -------- src/northbridge/intel/sandybridge/Kconfig | 8 -------- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index c7b2434721..69cdc8a5a4 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -1,5 +1,13 @@ menu "Architecture (x86)" +config MARK_GRAPHICS_MEM_WRCOMB + bool "Mark graphics memory as write-combining." + default n + help + The graphics performance may increase if the graphics + memory is set as write-combining cache type. This option + enables marking the graphics memory as write-combining. + # This is an SMP option. It relates to starting up APs. # It is usually set in mainboard/*/Kconfig. # TODO: Improve description. diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index 12f865a2e3..f68978040f 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -82,14 +82,6 @@ config DCACHE_RAM_ROMSTAGE_STACK_SIZE The amount of anticipated stack usage from the data cache during pre-ram rom stage execution. -config MARK_GRAPHICS_MEM_WRCOMB - bool "Mark graphics memory as write-combining." - default n - help - The graphics performance may increase if the graphics - memory is set as write-combining cache type. This option - enables marking the graphics memory as write-combining. - config HAVE_MRC bool "Add a System Agent binary" help diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 6c9ae99fcd..56d2cd7a38 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -107,14 +107,6 @@ config DCACHE_RAM_MRC_VAR_SIZE hex default 0x4000 -config MARK_GRAPHICS_MEM_WRCOMB - bool "Mark graphics memory as write-combining." - default n - help - The graphics performance may increase if the graphics - memory is set as write-combining cache type. This option - enables marking the graphics memory as write-combining. - config HAVE_MRC bool "Add a System Agent binary" help -- cgit v1.2.3