From 9fe0ff2f832dc58bfbb51032a7565c75e24a36c1 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Thu, 14 Jul 2016 01:38:31 -0500 Subject: mainboards: remove direct acpi_slp_type usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use the acpi_is_wakeup_s3() API instead of comparing a raw value to a global variable. This allows for easier refactoring. Change-Id: I2813b5d275cbe700be713272e3a88fdb5759db99 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/15690 Reviewed-by: Kyösti Mälkki Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Lee Leahy Reviewed-by: Matt DeVillier --- src/mainboard/google/cyan/ec.c | 2 +- src/mainboard/google/ninja/ec.c | 2 +- src/mainboard/intel/strago/ec.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/cyan/ec.c b/src/mainboard/google/cyan/ec.c index 8f516cb7da..cce7d705e1 100644 --- a/src/mainboard/google/cyan/ec.c +++ b/src/mainboard/google/cyan/ec.c @@ -28,7 +28,7 @@ void mainboard_ec_init(void) #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC) /* Restore SCI event mask on resume. */ - if (acpi_slp_type == 3) { + if (acpi_is_wakeup_s3()) { google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S3_WAKE_EVENTS); diff --git a/src/mainboard/google/ninja/ec.c b/src/mainboard/google/ninja/ec.c index 994b211a03..147cded0e9 100644 --- a/src/mainboard/google/ninja/ec.c +++ b/src/mainboard/google/ninja/ec.c @@ -26,7 +26,7 @@ void mainboard_ec_init(void) post_code(0xf0); /* Restore SCI event mask on resume. */ - if (acpi_slp_type == 3) { + if (acpi_is_wakeup_s3()) { google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S3_WAKE_EVENTS); diff --git a/src/mainboard/intel/strago/ec.c b/src/mainboard/intel/strago/ec.c index 0f8c55d9b8..dabe274fbf 100644 --- a/src/mainboard/intel/strago/ec.c +++ b/src/mainboard/intel/strago/ec.c @@ -28,7 +28,7 @@ void mainboard_ec_init(void) #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC) /* Restore SCI event mask on resume. */ - if (acpi_slp_type == 3) { + if (acpi_is_wakeup_s3()) { google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S3_WAKE_EVENTS); -- cgit v1.2.3