From 999b916015ea0558e3821bdb51501b43a60b5ed6 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Sat, 29 Sep 2018 08:03:06 -0700 Subject: mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD This change uses the generic device driver to provide DMIC properties in ACPI table to the OS driver. BUG=b:112888584 Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/28797 Reviewed-by: Aaron Durbin Reviewed-by: HARSHAPRIYA N Reviewed-by: Nick Vaccaro Reviewed-by: Sathyanarayana Nujella Tested-by: build bot (Jenkins) --- src/mainboard/google/poppy/Kconfig | 1 + src/mainboard/google/poppy/variants/nocturne/devicetree.cb | 13 ++++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index df59c5edbf..e75782268e 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -3,6 +3,7 @@ config BOARD_GOOGLE_BASEBOARD_POPPY def_bool n select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_GENERIC_GENERIC select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select EC_GOOGLE_CHROMEEC diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index df63a91fb3..a000efad99 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -438,7 +438,18 @@ chip soc/intel/skylake end # LPC Interface device pci 1f.1 on end # P2SB device pci 1f.2 on end # Power Management Controller - device pci 1f.3 on end # Intel HDA + device pci 1f.3 on + chip drivers/generic/generic + register "hid" = ""DMIC"" + register "name" = ""DMIC"" + register "desc" = ""Generic DMIC"" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""modeswitch_delay_ms"" + register "property_list[0].integer" = "35" + device generic 0 on end + end + end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI device pci 1f.6 off end # GbE -- cgit v1.2.3