From 9842bef5259202b0bc3cc85d6d82d76022764b77 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Thu, 31 Mar 2022 17:50:48 -0600 Subject: mb/google/skyrim: Fix ESPI communication issues * Use dedicated ALERT pin to resolve NO_RESPONSE error/status while getting target configuration. * Configure the ESPI to operate at 16 MHZ since operating at 33 MHz causes boot stall. BUG=b:226635441 TEST=Build and Boot to OS in Skyrim. Ensure that EC <-> AP communication is working fine through Host Command debug logs in EC console, ectool version command. Signed-off-by: Karthikeyan Ramasubramanian Change-Id: I951afdada8ee4f917cdeba8e287e5a2ae77c97ee Reviewed-on: https://review.coreboot.org/c/coreboot/+/63286 Reviewed-by: Jon Murphy Reviewed-by: Raul Rangel Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/skyrim/variants/baseboard/devicetree.cb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 8fa6ba5c2f..7f74d6d6fd 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -27,9 +27,9 @@ chip soc/amd/sabrina }, .io_mode = ESPI_IO_MODE_QUAD, - .op_freq_mhz = ESPI_OP_FREQ_33_MHZ, + .op_freq_mhz = ESPI_OP_FREQ_16_MHZ, .crc_check_enable = 1, - .alert_pin = ESPI_ALERT_PIN_IN_BAND, + .alert_pin = ESPI_ALERT_PIN_OPEN_DRAIN, .periph_ch_en = 1, .vw_ch_en = 1, .oob_ch_en = 0, -- cgit v1.2.3