From 93064ff7cd348f143b9c890a15b65680d3265525 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Mon, 24 Jun 2019 13:02:27 -0600 Subject: device/dram: Inline value into print statement By default printram() expands to nothing in normal builds, and so scan-build thinks that the assignment to reg8 is unused. Inline the value of reg8 into the print statement to silence the warning. Change-Id: I921fe08949c4135367bee9646b3b365097fab19e Signed-off-by: Jacob Garber Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33744 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/device/dram/ddr3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index 3272dac6d7..834dc83db6 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -382,8 +382,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd) dimm->flags.therm_sensor ? "yes" : "no"); /* SDRAM Device Type */ - reg8 = spd[33]; - printram(" Standard SDRAM : %s\n", (reg8 & 0x80) ? "no" : "yes"); + printram(" Standard SDRAM : %s\n", (spd[33] & 0x80) ? "no" : "yes"); if (spd[63] & 0x01) { dimm->flags.pins_mirrored = 1; -- cgit v1.2.3