From 91795a6da1c02e8af75cf52f9e28662a7947b204 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 25 May 2023 21:15:38 +0200 Subject: libpayload;arch,cpu/x86: drop USE_MARCH_586 Kconfig option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only the Intel Quark SoC selected this option and that SoC was dropped in commit 531023285ea4 ("soc/intel/quark: Drop support"), so drop this Kconfig option too. Signed-off-by: Felix Held Change-Id: Ic4f1c7530cd8ac7a1945b1493a2d53a7904daa06 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75473 Reviewed-by: Felix Singer Reviewed-by: Kyösti Mälkki Tested-by: build bot (Jenkins) --- payloads/libpayload/Kconfig | 8 -------- src/arch/x86/Kconfig | 6 ------ src/cpu/x86/entry32.S | 2 -- util/xcompile/xcompile | 6 +----- 4 files changed, 1 insertion(+), 21 deletions(-) diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig index fcef18a7f0..128c7daf0b 100644 --- a/payloads/libpayload/Kconfig +++ b/payloads/libpayload/Kconfig @@ -167,14 +167,6 @@ config BASE_ADDRESS endmenu -config USE_MARCH_586 - bool "Use march=586 qualifier to build" - default n - depends on ARCH_X86 - help - Allow a platform or processor to select to be compiled using - the '-march=i586' option instead of the typical '-march=i686' - menu "Standard Libraries" config LIBC diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 8d2295b7ad..b3cf96bb7a 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -92,12 +92,6 @@ config ARCH_X86_64_PGTBL_LOC The position where to place pagetables. Needs to be known at compile time. Must not overlap other files in CBFS. -config USE_MARCH_586 - def_bool n - help - Allow a platform or processor to select to be compiled using - the '-march=i586' option instead of the typical '-march=i686' - # This is an SMP option. It relates to starting up APs. # It is usually set in mainboard/*/Kconfig. # TODO: Improve description. diff --git a/src/cpu/x86/entry32.S b/src/cpu/x86/entry32.S index 215d60182a..4c8ded0bc7 100644 --- a/src/cpu/x86/entry32.S +++ b/src/cpu/x86/entry32.S @@ -54,7 +54,6 @@ debug_spinloop: jz debug_spinloop #endif -#if !CONFIG(USE_MARCH_586) /* MMX registers required here */ /* BIST result in eax */ @@ -66,7 +65,6 @@ __timestamp: rdtsc movd %eax, %mm1 movd %edx, %mm2 -#endif #if CONFIG(SSE) enable_sse: diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 7fba665121..a3f9be73f8 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -286,11 +286,7 @@ fi if [ "${TARCH}" = "x86_32" ]; then cat <