From 87837df807eeea39c08033a0f5b9a055926f6ae4 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Thu, 29 Jun 2023 21:09:52 +0200 Subject: acpi.c: Fix generating pointer to cb_tables located >4G Use the generic resource_consumer method which works for memory both above and below 4G. Signed-off-by: Arthur Heymans Change-Id: I1bc553b18d08cee502b765166227810f8e619631 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76181 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Lean Sheng Tan --- src/acpi/acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index db9c31646d..beba5fdb3a 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -300,7 +300,9 @@ static void acpi_ssdt_write_cbtable(void) acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); - acpigen_write_mem32fixed(0, base, size); + acpigen_resource_consumer_mmio(base, base + size - 1, + MEM_RSRC_FLAG_MEM_READ_ONLY + | MEM_RSRC_FLAG_MEM_ATTR_CACHE); acpigen_write_resourcetemplate_footer(); acpigen_pop_len(); } -- cgit v1.2.3