From 864be5bae5dea454a6867c39bdb12271bf39db3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Fri, 29 Jan 2021 15:20:33 +0200 Subject: mainboards: Remove default CHROMEOS=y MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even the boards with MAINBOARD_HAS_CHROMEOS need to be build-tested with CHROMEOS=n. Change-Id: I16fcf62a23dae1b21c77cee275c867f9c1de893b Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/50118 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Furquan Shaikh Reviewed-by: EricR Lai --- src/mainboard/google/brya/Kconfig | 2 -- src/mainboard/google/dedede/Kconfig | 2 -- src/mainboard/google/deltaur/Kconfig | 2 -- src/mainboard/google/drallion/Kconfig | 2 -- src/mainboard/google/hatch/Kconfig | 2 -- src/mainboard/google/octopus/Kconfig | 2 -- src/mainboard/google/sarien/Kconfig | 2 -- src/mainboard/google/volteer/Kconfig | 2 -- src/mainboard/intel/adlrvp/Kconfig | 2 -- src/mainboard/intel/coffeelake_rvp/Kconfig | 3 --- src/mainboard/intel/glkrvp/Kconfig | 2 -- src/mainboard/intel/jasperlake_rvp/Kconfig | 2 -- src/mainboard/intel/tglrvp/Kconfig | 2 -- 13 files changed, 27 deletions(-) diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index b691cd16e3..ca760780ed 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -22,8 +22,6 @@ config BASEBOARD_BRYA_LAPTOP select SYSTEM_TYPE_LAPTOP config CHROMEOS - bool - default y select EC_GOOGLE_CHROMEEC_SWITCHES select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 69280025ee..466a672eb8 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -38,8 +38,6 @@ config BASEBOARD_DEDEDE_LAPTOP select SYSTEM_TYPE_LAPTOP config CHROMEOS - bool - default y select CHROMEOS_CSE_BOARD_RESET_OVERRIDE select CHROMEOS_DRAM_PART_NUMBER_IN_CBI select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 8d958493bd..d351d85b96 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -22,8 +22,6 @@ config BOARD_GOOGLE_BASEBOARD_DELTAUR if BOARD_GOOGLE_BASEBOARD_DELTAUR config CHROMEOS - bool - default y select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 747010702c..311f3f6c0b 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -28,8 +28,6 @@ config BOARD_GOOGLE_BASEBOARD_DRALLION if BOARD_GOOGLE_BASEBOARD_DRALLION config CHROMEOS - bool - default y select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index d088341324..1c10522455 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -45,8 +45,6 @@ config BOARD_GOOGLE_HATCH_COMMON if BOARD_GOOGLE_HATCH_COMMON config CHROMEOS - bool - default y select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if !ROMSTAGE_SPD_SMBUS select EC_GOOGLE_CHROMEEC_SWITCHES select GBB_FLAG_FORCE_DEV_SWITCH_ON diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 7e8e277e17..ba01fe3d5f 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -43,8 +43,6 @@ config BASEBOARD_OCTOPUS_LAPTOP select SYSTEM_TYPE_LAPTOP config CHROMEOS - bool - default y select EC_GOOGLE_CHROMEEC_SWITCHES select HAS_RECOVERY_MRC_CACHE select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 444234af45..9893acfb78 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -31,8 +31,6 @@ config BOARD_GOOGLE_BASEBOARD_SARIEN if BOARD_GOOGLE_BASEBOARD_SARIEN config CHROMEOS - bool - default y select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 3217d07f71..f4d121ed3d 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -38,8 +38,6 @@ config BOARD_GOOGLE_BASEBOARD_VOLTEER if BOARD_GOOGLE_BASEBOARD_VOLTEER config CHROMEOS - bool - default y select CHROMEOS_CSE_BOARD_RESET_OVERRIDE select CHROMEOS_DRAM_PART_NUMBER_IN_CBI select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig index 35224a14ce..80d52548fb 100644 --- a/src/mainboard/intel/adlrvp/Kconfig +++ b/src/mainboard/intel/adlrvp/Kconfig @@ -18,8 +18,6 @@ config BOARD_SPECIFIC_OPTIONS select PCIEXP_HOTPLUG config CHROMEOS - bool - default y select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index 0f8075bf4f..e4c2d90a95 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -44,9 +44,6 @@ config MAINBOARD_FAMILY default "Intel_cflrvp" config CHROMEOS - bool - default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 - default y select GBB_FLAG_FORCE_MANUAL_RECOVERY config MAX_CPUS diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 172dfa2e97..7fda90d98a 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -38,8 +38,6 @@ config GLK_INTEL_EC endchoice config CHROMEOS - bool - default y select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select VBOOT_LID_SWITCH if GLK_CHROME_EC diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 7bfd15878c..8dec42a2a8 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -51,8 +51,6 @@ config DIMM_SPD_SIZE default 512 config CHROMEOS - bool - default y select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 9df542dfa6..233706d949 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -26,8 +26,6 @@ config BOARD_SPECIFIC_OPTIONS select SPI_TPM config CHROMEOS - bool - default y select EC_GOOGLE_CHROMEEC_SWITCHES if TGL_CHROME_EC select GBB_FLAG_FORCE_MANUAL_RECOVERY select HAS_RECOVERY_MRC_CACHE -- cgit v1.2.3