From 7bde4e80be27b35abf13114eb8b6096755458d2e Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Fri, 2 Dec 2022 08:42:04 +0100 Subject: superio/ite/it8772f/chip.h: Use 'bool' when appropriate Change-Id: I20c3298a920396718f0dc036e57faf8e46b82b2c Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/70253 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/beltino/devicetree.cb | 4 ++-- src/mainboard/google/jecht/devicetree.cb | 4 ++-- src/mainboard/samsung/stumpy/devicetree.cb | 4 ++-- src/superio/ite/it8772f/chip.h | 10 ++++++---- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mainboard/google/beltino/devicetree.cb b/src/mainboard/google/beltino/devicetree.cb index 18ec581fc0..cdaab35b54 100644 --- a/src/mainboard/google/beltino/devicetree.cb +++ b/src/mainboard/google/beltino/devicetree.cb @@ -79,11 +79,11 @@ chip northbridge/intel/haswell end chip superio/ite/it8772f # Skip keyboard init - register "skip_keyboard" = "1" + register "skip_keyboard" = "true" # Enable PECI on TMPIN3 register "peci_tmpin" = "3" # Enable FAN2 - register "fan2_enable" = "1" + register "fan2_enable" = "true" device pnp 2e.0 off end # FDC device pnp 2e.1 on # Serial Port 1 diff --git a/src/mainboard/google/jecht/devicetree.cb b/src/mainboard/google/jecht/devicetree.cb index 59cf071629..1bf8a2aefb 100644 --- a/src/mainboard/google/jecht/devicetree.cb +++ b/src/mainboard/google/jecht/devicetree.cb @@ -73,7 +73,7 @@ chip soc/intel/broadwell end chip superio/ite/it8772f # Skip keyboard init - register "skip_keyboard" = "1" + register "skip_keyboard" = "true" # Enable PECI on TMPIN3 register "peci_tmpin" = "3" # Disable use of TMPIN1 @@ -81,7 +81,7 @@ chip soc/intel/broadwell # Enable Thermal Diode on TMPIN2 register "tmpin2_mode" = "1" # Enable FAN2 - register "fan2_enable" = "1" + register "fan2_enable" = "true" # Default FAN2 speed register "fan2_speed" = "0x4d" diff --git a/src/mainboard/samsung/stumpy/devicetree.cb b/src/mainboard/samsung/stumpy/devicetree.cb index 10aeb44127..b348f140cc 100644 --- a/src/mainboard/samsung/stumpy/devicetree.cb +++ b/src/mainboard/samsung/stumpy/devicetree.cb @@ -69,11 +69,11 @@ chip northbridge/intel/sandybridge # Enable GPIO52 as USBPWRON1# register "gpio_set5" = "0x06" # Skip keyboard init - register "skip_keyboard" = "1" + register "skip_keyboard" = "true" # Enable PECI on TMPIN3 register "peci_tmpin" = "3" # Enable FAN3 - register "fan3_enable" = "1" + register "fan3_enable" = "true" device pnp 2e.0 off end # FDC device pnp 2e.1 on # Serial Port 1 diff --git a/src/superio/ite/it8772f/chip.h b/src/superio/ite/it8772f/chip.h index 19f1f7d6aa..eb3ccd2a97 100644 --- a/src/superio/ite/it8772f/chip.h +++ b/src/superio/ite/it8772f/chip.h @@ -4,6 +4,8 @@ #define SUPERIO_ITE_IT8772F_CHIP_H #include +#include + #include "it8772f.h" struct superio_ite_it8772f_config { @@ -15,7 +17,7 @@ struct superio_ite_it8772f_config { u8 gpio_set5; u8 gpio_set6; - u8 skip_keyboard; + bool skip_keyboard; /* * Enable external temperature sensor to use PECI GetTemp() @@ -32,9 +34,9 @@ struct superio_ite_it8772f_config { /* * Enable a FAN for software control. */ - u8 fan1_enable; - u8 fan2_enable; - u8 fan3_enable; + bool fan1_enable; + bool fan2_enable; + bool fan3_enable; /* * Default FAN speed -- cgit v1.2.3