From 7a52c17f16e84e2c7f61eac78c2534927d42dbba Mon Sep 17 00:00:00 2001 From: Richard Spiegel Date: Thu, 26 Apr 2018 08:19:12 -0700 Subject: soc/amd/stoneyridge/gpio.c: Fix gpio_output() Function gpio_output() is only setting the pin as an output, when in fact it should also set the state (high/low) of the pin. Fix the procedure to set the state of the pin. BUG=b:78328773 TEST=None Change-Id: I516192a0782a9bbb40124029f264a2711114c800 Signed-off-by: Richard Spiegel Reviewed-on: https://review.coreboot.org/25871 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Aaron Durbin Reviewed-by: Paul Menzel --- src/soc/amd/stoneyridge/gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c index 088f1990d5..4520df7a6f 100644 --- a/src/soc/amd/stoneyridge/gpio.c +++ b/src/soc/amd/stoneyridge/gpio.c @@ -95,6 +95,7 @@ void gpio_output(gpio_t gpio_num, int value) reg = read32((void *)gpio_address); reg |= GPIO_OUTPUT_ENABLE; write32((void *)(uintptr_t)gpio_num, reg); + gpio_set(gpio_num, value); } const char *gpio_acpi_path(gpio_t gpio) -- cgit v1.2.3