From 78fc3fc1057b5b0d42d3446f6e22fa03fbc1a4e4 Mon Sep 17 00:00:00 2001 From: Jonathan Neuschäfer Date: Sat, 2 Sep 2017 19:22:18 +0200 Subject: arch/x86/Kconfig: Add deprecation warnings for LATE_CBMEM_INIT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The deprecation of late (post-romstage) CBMEM initialization was announced in this blog post: https://blogs.coreboot.org/blog/2017/05/08/announcing-coreboot-4-6/ There are two warnings: * In LATE_CBMEM_INIT's help text, I've added a multi-line warning, that aims to explain the problem. * In src/mainboard/Kconfig (just below the mainboard selection), there's a warning which points the user at LATE_CBMEM_INIT, if such a board is selected. Also update the function that needs to be implemented, as pointed out by Keith Hui and Kyösti Mälkki. Change-Id: I2d21a6ab2fc2811d44fc4febb05841bb2f8d1857 Signed-off-by: Jonathan Neuschäfer Reviewed-on: https://review.coreboot.org/21112 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/arch/x86/Kconfig | 8 ++++++-- src/mainboard/Kconfig | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index dbfb8810c5..726fa31f71 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -122,8 +122,12 @@ config LATE_CBMEM_INIT select CBMEM_TOP_BACKUP help Enable this in chipset's Kconfig if northbridge does not implement - early get_top_of_ram() call for romstage. CBMEM tables will be - allocated late in ramstage, after PCI devices resources are known. + early cbmem_top() call for romstage. CBMEM tables will be allocated + late in ramstage, after PCI devices resources are known. + + WARNING: Late CBMEM initialization is deprecated. Platforms that + don't support early CBMEM initialization will be removed after + the release of coreboot 4.7. config PRERAM_CBMEM_CONSOLE_SIZE hex diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index bdaa9e75c9..47338ace83 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -10,6 +10,9 @@ endchoice source "src/mainboard/*/Kconfig" +comment "WARNING: This mainboard uses LATE_CBMEM_INIT, which is deprecated" + depends on LATE_CBMEM_INIT + config BOARD_ROMSIZE_KB_64 bool config BOARD_ROMSIZE_KB_128 -- cgit v1.2.3