From 78d14326987547f7ae8b2a5b200cb1f3fba0fb31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Wed, 23 Jan 2019 15:57:49 +0200 Subject: device/pci_ops: Drop parameter from pci_bus_default_ops() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A default is a build-time static value, fallback. Return value does not depend of input parameter. Change-Id: I43ae28f465fb46391519ec97a2a50891d458c46d Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/31679 Reviewed-by: Felix Held Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/arch/x86/pci_ops.c | 2 +- src/device/pci_ops.c | 2 +- src/device/pci_ops_mmconf.c | 2 +- src/include/device/pci_ops.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/arch/x86/pci_ops.c b/src/arch/x86/pci_ops.c index 82f9fd2644..f30bffe320 100644 --- a/src/arch/x86/pci_ops.c +++ b/src/arch/x86/pci_ops.c @@ -16,7 +16,7 @@ #include #include -const struct pci_bus_operations *pci_bus_default_ops(struct device *dev) +const struct pci_bus_operations *pci_bus_default_ops(void) { return &pci_cf8_conf1; } diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c index de0bf631b1..b7c8942ae0 100644 --- a/src/device/pci_ops.c +++ b/src/device/pci_ops.c @@ -27,7 +27,7 @@ static const struct pci_bus_operations *pci_bus_ops(struct bus *bus, struct devi bops = bus->dev->ops->ops_pci_bus(dev); } if (!bops) - bops = pci_bus_default_ops(dev); + bops = pci_bus_default_ops(); return bops; } diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c index 8b7b57452f..0af8f8e28b 100644 --- a/src/device/pci_ops_mmconf.c +++ b/src/device/pci_ops_mmconf.c @@ -71,7 +71,7 @@ static const struct pci_bus_operations pci_ops_mmconf = { .write32 = pci_mmconf_write_config32, }; -const struct pci_bus_operations *pci_bus_default_ops(struct device *dev) +const struct pci_bus_operations *pci_bus_default_ops(void) { return &pci_ops_mmconf; } diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h index 6bcb3e95b1..6971ce4de7 100644 --- a/src/include/device/pci_ops.h +++ b/src/include/device/pci_ops.h @@ -24,7 +24,7 @@ u32 pci_read_config32(struct device *dev, unsigned int where); void pci_write_config8(struct device *dev, unsigned int where, u8 val); void pci_write_config16(struct device *dev, unsigned int where, u16 val); void pci_write_config32(struct device *dev, unsigned int where, u32 val); -const struct pci_bus_operations *pci_bus_default_ops(struct device *dev); +const struct pci_bus_operations *pci_bus_default_ops(void); #endif #ifdef __SIMPLE_DEVICE__ -- cgit v1.2.3