From 74ab031ba130bd5d655d7b6ac603013a079eb97d Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Fri, 17 Aug 2018 18:36:56 +0200 Subject: ec/lenovo/pmh7: use read/write function in clear_bit/set_bit Make the code simpler and improve readability. Change-Id: Ifa9308c32e4646c122254931b55fb83541a10a3c Signed-off-by: Alexander Couzens Reviewed-on: https://review.coreboot.org/28195 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Paul Menzel --- src/ec/lenovo/pmh7/pmh7.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c index c9756795a0..b160fd0bc1 100644 --- a/src/ec/lenovo/pmh7/pmh7.c +++ b/src/ec/lenovo/pmh7/pmh7.c @@ -68,20 +68,16 @@ void pmh7_register_set_bit(int reg, int bit) { char val; - outb(reg, EC_LENOVO_PMH7_ADDR); - val = inb(EC_LENOVO_PMH7_DATA); - outb(reg, EC_LENOVO_PMH7_ADDR); - outb(val | (1 << bit), EC_LENOVO_PMH7_DATA); + val = pmh7_register_read(reg); + pmh7_register_write(reg, val | (1 << bit)); } void pmh7_register_clear_bit(int reg, int bit) { char val; - outb(reg, EC_LENOVO_PMH7_ADDR); - val = inb(EC_LENOVO_PMH7_DATA); - outb(reg, EC_LENOVO_PMH7_ADDR); - outb(val &= ~(1 << bit), EC_LENOVO_PMH7_DATA); + val = pmh7_register_read(reg); + pmh7_register_write(reg, val & ~(1 << bit)); } char pmh7_register_read(int reg) -- cgit v1.2.3