From 6fe7986daf7d7915f27b2e30aa120fce7d834c6e Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 13 Oct 2020 21:39:13 +0200 Subject: nb/intel/haswell: Drop unnecessary register read Reading MAD_CHNL has no effect, so there's no need to read it here. Change-Id: I8d2aa4787de7f54f49d161f61c9c0abaa811cb83 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/46361 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/northbridge/intel/haswell/raminit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index 9c6c00ff16..aaeaadf9ae 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -227,8 +227,6 @@ void setup_sdram_meminfo(struct pei_data *pei_data) memset(mem_info, 0, sizeof(struct memory_info)); - /* FIXME: Do we need to read MCHBAR32(MAD_CHNL) ? (Answer: Nope) */ - MCHBAR32(MAD_CHNL); addr_decode_ch[0] = MCHBAR32(MAD_DIMM_CH0); addr_decode_ch[1] = MCHBAR32(MAD_DIMM_CH1); -- cgit v1.2.3