From 671cd1d16bcb83069cac810ca2df4f2b4d056491 Mon Sep 17 00:00:00 2001 From: Jan Samek Date: Fri, 27 Jan 2023 11:02:20 +0100 Subject: drv/i2c/ptn3460: Use PTN_EDID_LEN instead of constant Contents of the EDID are passed by a reference to an array of length 0x80, for which the macro 'PTN_EDID_LEN' has already been around. This patch makes use of this macro within the driver and mainboard implementation utilizing it. BUG=none TEST=A successful build of mc_apl{1,4,5,7} and mc_ehl3 mainboards. Change-Id: If7d254aaf45d717133bb426bd08f8f9fe5c05962 Signed-off-by: Jan Samek Reviewed-on: https://review.coreboot.org/c/coreboot/+/72653 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer --- src/drivers/i2c/ptn3460/ptn3460.c | 2 +- src/drivers/i2c/ptn3460/ptn3460.h | 2 +- src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c | 2 +- src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c | 2 +- src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c | 2 +- src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c | 2 +- src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/drivers/i2c/ptn3460/ptn3460.c b/src/drivers/i2c/ptn3460/ptn3460.c index 31db8ad7fe..d2df04d216 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.c +++ b/src/drivers/i2c/ptn3460/ptn3460.c @@ -123,7 +123,7 @@ static void ptn3460_init(struct device *dev) init_done = true; } -__weak enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +__weak enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { return CB_ERR; } diff --git a/src/drivers/i2c/ptn3460/ptn3460.h b/src/drivers/i2c/ptn3460/ptn3460.h index 5d867cdd46..ecd2191f39 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.h +++ b/src/drivers/i2c/ptn3460/ptn3460.h @@ -52,7 +52,7 @@ struct ptn_3460_flash { /* We need functions which we can call to get mainboard specific data */ /* These functions can be implemented somewhere else but must exist. */ -extern enum cb_err mb_get_edid(uint8_t edid_data[0x80]); +extern enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]); extern uint8_t mb_select_edid_table(void); extern enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg_ptr); diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c index 0fce19c80b..8a20f364d5 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c index d5de17dd52..39cc274e21 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c index 348f7622ae..c74e90ab61 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c @@ -33,7 +33,7 @@ static void igd_disable(void) * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c index d5de17dd52..39cc274e21 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c index 7b162540aa..316eb71eba 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; -- cgit v1.2.3