From 664f0c51e75f4ee168f28e549bb45782c0473d2e Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 24 May 2022 22:14:18 +0100 Subject: mb/starlabs/lite/glkr: Don't configure GPIO's 147 through 156 These are configured by the TXE, so they do not need to be configured. Signed-off-by: Sean Rhodes Change-Id: I13957992d637a53203b4328e39c0e6607e017891 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64653 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/mainboard/starlabs/lite/variants/glkr/gpio.c | 34 ++++++++---------------- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/src/mainboard/starlabs/lite/variants/glkr/gpio.c b/src/mainboard/starlabs/lite/variants/glkr/gpio.c index e4dd10f58f..6bf8b6120d 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/gpio.c +++ b/src/mainboard/starlabs/lite/variants/glkr/gpio.c @@ -322,31 +322,19 @@ const struct pad_config gpio_table[] = { PAD_NC(GPIO_145, DN_20K), /* GPIO_146: Not Connected */ PAD_NC(GPIO_146, DN_20K), - _PAD_CFG_STRUCT(GPIO_147, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSTERM(ENPU)), - _PAD_CFG_STRUCT(GPIO_148, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(HIZCRx1)), - _PAD_CFG_STRUCT(GPIO_149, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(HIZCRx1)), - _PAD_CFG_STRUCT(GPIO_150, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) | - PAD_IOSTERM(ENPU)), - _PAD_CFG_STRUCT(GPIO_151, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) | - PAD_IOSTERM(ENPU)), - _PAD_CFG_STRUCT(GPIO_152, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) | - PAD_IOSTERM(ENPU)), _PAD_CFG_STRUCT(GPIO_153, PAD_FUNC(NF1) | PAD_RESET(DEEP) | - PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) | - PAD_IOSTERM(ENPU)), _PAD_CFG_STRUCT(GPIO_154, PAD_FUNC(NF1) | PAD_RESET(DEEP) | - PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), - _PAD_CFG_STRUCT(GPIO_155, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | - PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) | - PAD_IOSTERM(ENPU)), + /* GPIO 147 through 156 are configured by the TXE */ + /* GPIO_147: LPC_SERIRQ */ + /* GPIO_148: LPC_CLK0 */ + /* GPIO_149: LPC_CLK_DBG_CPU */ + /* GPIO_150: LPC_AD0 */ + /* GPIO_151: LPC_AD1 */ + /* GPIO_152: LPC_AD2 */ + /* GPIO_153: LPC_AD3 */ + /* GPIO_154: LPC_CLKRUN# */ + /* GPIO_155: LPC_FRAME# */ /* ----- GPIO Group Audio ----- */ + /* GPIO_156: FP_INT# */ /* GPIO_157: Not Connected */ PAD_NC(GPIO_157, DN_20K), /* GPIO_158: Not Connected */ -- cgit v1.2.3