From 6319ef97183fe46e0e0e6bdcb5c83aa605db5491 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 23 Aug 2023 12:43:38 +0100 Subject: soc/intel/apollolake: Correct the logic for the legacy 8254 timer The `use_8254` should be flipped, the same as the other Intel SOCs. Signed-off-by: Sean Rhodes Change-Id: I2d6c859c0910b796d2ae5874a560ff9974578106 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77409 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/soc/intel/apollolake/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 0e54fd8291..37b3186af5 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -749,7 +749,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd) /* 8254 Timer */ bool use_8254 = get_uint_option("legacy_8254_timer", CONFIG(USE_LEGACY_8254_TIMER)); - silconfig->Timer8254ClkSetting = use_8254; + silconfig->Timer8254ClkSetting = !use_8254; /* FSP should let coreboot set subsystem IDs, which are read/write-once */ silconfig->SubSystemVendorId = 0; -- cgit v1.2.3