From 60fccdc3d2ab5a3b0265f1a411d02b8504407e1c Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Sun, 5 Oct 2014 11:05:16 +0200 Subject: acpi_create_mcfg_mmconfig: Zero-out the structure before filling. Otherwise "reserved" fields end up with a garbage instead of predictable value. Change-Id: I8a036769a8f86f1d6752651601de2800f4f1bd00 Signed-off-by: Vladimir Serbinenko Reviewed-on: http://review.coreboot.org/7014 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/arch/x86/boot/acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/arch/x86/boot/acpi.c b/src/arch/x86/boot/acpi.c index 3bfa3bdaaf..3a30d31b71 100644 --- a/src/arch/x86/boot/acpi.c +++ b/src/arch/x86/boot/acpi.c @@ -118,6 +118,7 @@ void acpi_add_table(acpi_rsdp_t *rsdp, void *table) int acpi_create_mcfg_mmconfig(acpi_mcfg_mmconfig_t *mmconfig, u32 base, u16 seg_nr, u8 start, u8 end) { + memset(mmconfig, 0, sizeof(*mmconfig)); mmconfig->base_address = base; mmconfig->base_reserved = 0; mmconfig->pci_segment_group_number = seg_nr; -- cgit v1.2.3