From 5df952bc2bcf97f884e9e6fbeabc8d64233590b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Fri, 2 Oct 2020 17:57:47 +0200 Subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, the ACPI PM timer state gets set in devicetree by the option PmTimerDisabled. However, it is not board design dependent. Thus, add a user-selectable Kconfig option. Disabling the PM ACPI Timer is only valid when PM Timer emulation is supported and is only possible, when there is a hardware PM Timer (APL does not have one for example). SoCs, where the hardware PM Timer can be disabled must select `PM_ACPI_TIMER_OPTIONAL`. This new Kconfig gets used in the follow-up commits of this series. Change-Id: I7f607f277eb14f84a7370ffb25a13226e7ccc917 Signed-off-by: Michael Niewöhner Reviewed-on: https://review.coreboot.org/c/coreboot/+/45952 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/soc/intel/common/block/pmc/Kconfig | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/soc/intel/common/block/pmc/Kconfig b/src/soc/intel/common/block/pmc/Kconfig index 5cb2bea1d9..b420865c92 100644 --- a/src/soc/intel/common/block/pmc/Kconfig +++ b/src/soc/intel/common/block/pmc/Kconfig @@ -43,3 +43,25 @@ config PMC_LOW_POWER_MODE_PROGRAM help Enable this for PMC devices to perform registers programming to ensure low power in active idle scenario. + +config PM_ACPI_TIMER_OPTIONAL + bool + default n + help + This needs to be selected by SoCs, where the hardware PM Timer + can be disabled, to show the ACPI PM Timer Kconfig in menuconfig. + +if PM_ACPI_TIMER_OPTIONAL + +config USE_PM_ACPI_TIMER + bool "Enable ACPI PM timer" + default y + help + This should be disabled for devices running on battery since + it can draw much power. Further, it must be disabled, if S0ix + is enabled. + + Disabling this option also stops the hardware TCO timer and makes + the TCO watchdog unavailable. + +endif # PM_ACPI_TIMER_OPTIONAL -- cgit v1.2.3