From 5ca1683b324145e791350643eec389f2cd940b40 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Mon, 18 Nov 2024 09:41:24 +0100 Subject: soc/intel/xeon_sp: Drop DMAR_X2APIC_OPT_OUT Drop DMAR_X2APIC_OPT_OUT since coreboot is able to enable X2APIC. TEST: Works fine on OCP/tiogapass, thus drop the opt out. Change-Id: Ia0443a39a9bf392976cfd1a7ccf6a335d5f0bd70 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/85173 Tested-by: build bot (Jenkins) Reviewed-by: Shuo Liu --- src/soc/intel/xeon_sp/uncore_acpi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index a694d08abc..2d0baf9b40 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -588,11 +588,6 @@ unsigned long northbridge_write_acpi_tables(const struct device *device, unsigne current = ALIGN_UP(current, 8); dmar = (acpi_dmar_t *)current; enum dmar_flags flags = DMAR_INTR_REMAP; - - /* SKX FSP doesn't support X2APIC, but CPX FSP does */ - if (CONFIG(SOC_INTEL_SKYLAKE_SP)) - flags |= DMAR_X2APIC_OPT_OUT; - printk(BIOS_DEBUG, "ACPI: * DMAR at %lx\n", current); printk(BIOS_DEBUG, "[DMA Remapping table] Flags: 0x%x\n", flags); acpi_create_dmar(dmar, flags, acpi_fill_dmar); -- cgit v1.2.3