From 5bcf8d637becc29aaaf2ed1797e6fe89bf1c07f8 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Tue, 16 Jun 2015 13:02:40 -0700 Subject: t210: MTC cleanup 1. Correct MTC weak function definitions. 2. Correct MTC message in case no training data is present. BUG=None BRANCH=None TEST=Compiles successfully and boots to kernel prompt on smaug. Change-Id: Iba3c994982da947af3fbd2d7e9a06dff7947f2b9 Signed-off-by: Patrick Georgi Original-Commit-Id: ce9a4cd7d824acd0da5615b33319869f6cf1cd56 Original-Change-Id: I037439246709c8ec0ec7f12ea109cbe0ae1073ae Original-Signed-off-by: Furquan Shaikh Original-Reviewed-on: https://chromium-review.googlesource.com/278027 Original-Trybot-Ready: Furquan Shaikh Original-Tested-by: Furquan Shaikh Original-Reviewed-by: Tom Warren Original-Reviewed-by: Stefan Reinauer Original-Reviewed-by: Patrick Georgi Original-Commit-Queue: Furquan Shaikh Reviewed-on: http://review.coreboot.org/10780 Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/soc/nvidia/tegra210/include/soc/mtc.h | 2 +- src/soc/nvidia/tegra210/soc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/nvidia/tegra210/include/soc/mtc.h b/src/soc/nvidia/tegra210/include/soc/mtc.h index c94d79b988..c9f19cbc57 100644 --- a/src/soc/nvidia/tegra210/include/soc/mtc.h +++ b/src/soc/nvidia/tegra210/include/soc/mtc.h @@ -29,7 +29,7 @@ void soc_add_mtc(struct lb_header *header); #else -static inline int tegra210_run_mtc(void) { return -1; } +static inline int tegra210_run_mtc(void) { return 0; } static inline void soc_add_mtc(struct lb_header *header) {} #endif /* CONFIG_HAVE_MTC */ diff --git a/src/soc/nvidia/tegra210/soc.c b/src/soc/nvidia/tegra210/soc.c index f3290c3ac6..7d91bc5468 100644 --- a/src/soc/nvidia/tegra210/soc.c +++ b/src/soc/nvidia/tegra210/soc.c @@ -156,7 +156,7 @@ static void tegra210_cpu_init(device_t cpu) { if (cpu_is_bsp()) if (tegra210_run_mtc() != 0) - printk(BIOS_ERR, "MTC: Training failed\n"); + printk(BIOS_ERR, "MTC: No training data.\n"); } static const struct cpu_device_id ids[] = { -- cgit v1.2.3