From 5793b7371dd82ad688164122850d63cdbda56859 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 9 Jun 2015 15:02:50 -0500 Subject: x86: remove printk() from init_timer() For console drivers which use udelay() we can deadlock in the printk path on the spinlock. The reason is that on the first call to udelay() from within a console driver it will go back down the printk() path deadlocking oneself. Just remove the printk() as it was asymmetric on romstage vs ramstage. Change-Id: I30fe7d6e5b4684f17d4f353c0816b64f9242de0a Signed-off-by: Aaron Durbin Reviewed-on: http://review.coreboot.org/10483 Reviewed-by: Patrick Georgi Tested-by: build bot (Jenkins) --- src/cpu/x86/tsc/delay_tsc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cpu/x86/tsc/delay_tsc.c b/src/cpu/x86/tsc/delay_tsc.c index 5aaba90ed9..0ad5d3bbdf 100644 --- a/src/cpu/x86/tsc/delay_tsc.c +++ b/src/cpu/x86/tsc/delay_tsc.c @@ -152,10 +152,8 @@ static unsigned long long calibrate_tsc(void) void init_timer(void) { - if (!clocks_per_usec) { + if (!clocks_per_usec) clocks_per_usec = calibrate_tsc(); - printk(BIOS_INFO, "clocks_per_usec: %lu\n", clocks_per_usec); - } } static inline unsigned long get_clocks_per_usec(void) -- cgit v1.2.3