From 5407310e64ea34b41ca4226ad724642f2b5de8fa Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Mon, 1 Aug 2016 23:18:29 +0200 Subject: cbfstool: Check for excessive arguments Change-Id: I66de6a33b43c284198c0a0a97c5c6a10f9b96e02 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/16019 Tested-by: build bot (Jenkins) Reviewed-by: Omar Pakker Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- util/cbfstool/cbfstool.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index e1bdf2f71a..e70cb4b0b8 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -1296,8 +1296,14 @@ int main(int argc, char **argv) c = getopt_long(argc, argv, commands[i].optstring, long_options, &option_index); - if (c == -1) + if (c == -1) { + if (optind < argc) { + ERROR("%s: excessive argument -- '%s'" + "\n", argv[0], argv[optind]); + return 1; + } break; + } /* filter out illegal long options */ if (strchr(commands[i].optstring, c) == NULL) { -- cgit v1.2.3