From 4dc9fb026cf1834d5b99baee8f265ad6cebf8fc6 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 11 Jul 2017 17:29:02 -0600 Subject: soc/intel/skylake: reduce postcar stack usage for fsp 2.0 The FSP 2.0 path uses postcar to decompress ramstage. Since postcar is entirely RAM based there's no need to have an excessively large stack for the lzma decompression buffer. Therefore, reduce the stack required to 1 KiB like apollolake. Change-Id: I45e5c283f8ae87e701c94d6a123463dddde3f221 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/20536 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Lijian Zhao Reviewed-by: Furquan Shaikh --- src/soc/intel/skylake/romstage/romstage_fsp20.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c index 093f7c09b9..1c63250d1f 100644 --- a/src/soc/intel/skylake/romstage/romstage_fsp20.c +++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c @@ -36,12 +36,6 @@ #include #include -/* - * Romstage needs some stack for decompressing ramstage images, since the lzma - * lib keeps its state on the stack during romstage. - */ -#define ROMSTAGE_RAM_STACK_SIZE 0x5000 - #define FSP_SMBIOS_MEMORY_INFO_GUID \ { \ 0xd4, 0x71, 0x20, 0x9b, 0x54, 0xb0, 0x0c, 0x4e, \ @@ -134,7 +128,7 @@ asmlinkage void car_stage_entry(void) pmc_set_disb(); if (!s3wake) save_dimm_info(); - if (postcar_frame_init(&pcf, ROMSTAGE_RAM_STACK_SIZE)) + if (postcar_frame_init(&pcf, 1*KiB)) die("Unable to initialize postcar frame.\n"); /* -- cgit v1.2.3