From 47a0b8494b59cf292dcc3372a01ee597b6de3923 Mon Sep 17 00:00:00 2001 From: robbie zhang Date: Thu, 10 Sep 2015 16:24:44 -0700 Subject: glados/kunimitsu: remove the implementation of mainboard_add_dimm_info This is a follow-up patch to https://chromium-review.googlesource.com/#/c/286877, after fsp support is landed in v1.5. BUG=chrome-os-partner:42975 BRANCH=none TEST=execute "mosys memory spd print all" on glados and kunimitsu Change-Id: I949e287372b190affac36a0efde8a30402eecdc8 Signed-off-by: Patrick Georgi Original-Commit-Id: 71a2e1838ff8bbaa358c167dad905b63d23c43fa Original-Change-Id: I64103af4f8456a053a955845a067062122f47af3 Original-Signed-off-by: Robbie Zhang Original-Reviewed-on: https://chromium-review.googlesource.com/298967 Original-Reviewed-by: Duncan Laurie Reviewed-on: http://review.coreboot.org/11657 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/google/glados/romstage.c | 16 ---------------- src/mainboard/intel/kunimitsu/romstage.c | 16 ---------------- 2 files changed, 32 deletions(-) diff --git a/src/mainboard/google/glados/romstage.c b/src/mainboard/google/glados/romstage.c index 315ddb9de8..69e6e0d872 100644 --- a/src/mainboard/google/glados/romstage.c +++ b/src/mainboard/google/glados/romstage.c @@ -21,7 +21,6 @@ #include #include -#include #include #include #include @@ -77,18 +76,3 @@ void mainboard_memory_init_params(struct romstage_params *params, memory_params->MemorySpdDataLen = SPD_LEN; memory_params->DqPinsInterleaved = FALSE; } - -void mainboard_add_dimm_info(struct romstage_params *params, - struct memory_info *mem_info, - int channel, int dimm, int index) -{ - /* Set the manufacturer */ - memcpy(&mem_info->dimm[index].mod_id, - ¶ms->pei_data->spd_data[channel][dimm][SPD_MANU_OFF], - sizeof(mem_info->dimm[index].mod_id)); - - /* Set the module part number */ - memcpy(mem_info->dimm[index].module_part_number, - ¶ms->pei_data->spd_data[channel][dimm][SPD_PART_OFF], - sizeof(mem_info->dimm[index].module_part_number)); -} diff --git a/src/mainboard/intel/kunimitsu/romstage.c b/src/mainboard/intel/kunimitsu/romstage.c index af16dced97..a0eeafc9a5 100644 --- a/src/mainboard/intel/kunimitsu/romstage.c +++ b/src/mainboard/intel/kunimitsu/romstage.c @@ -21,7 +21,6 @@ #include #include -#include #include #include #include @@ -77,18 +76,3 @@ void mainboard_memory_init_params(struct romstage_params *params, memory_params->MemorySpdDataLen = SPD_LEN; memory_params->DqPinsInterleaved = FALSE; } - -void mainboard_add_dimm_info(struct romstage_params *params, - struct memory_info *mem_info, - int channel, int dimm, int index) -{ - /* Set the manufacturer */ - memcpy(&mem_info->dimm[index].mod_id, - ¶ms->pei_data->spd_data[channel][dimm][SPD_MANU_OFF], - sizeof(mem_info->dimm[index].mod_id)); - - /* Set the module part number */ - memcpy(mem_info->dimm[index].module_part_number, - ¶ms->pei_data->spd_data[channel][dimm][SPD_PART_OFF], - sizeof(mem_info->dimm[index].module_part_number)); -} -- cgit v1.2.3