From 45d2c3d5436e30178dae1c95c53de38ff9b45a35 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 1 Aug 2024 08:51:59 +0100 Subject: i2c/drivers/generic: Return ROTM in a package The ROTM method should return a package: ``` Name (RBUF, Package (0x03) { "0 1 0", "1 0 0", "0 0 1" }) Return (RBUF) ``` Adjust the acpigen to do this. Change-Id: Id493f6955c1d0dc3449402262a8575091a828226 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/83721 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/drivers/i2c/generic/generic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 1875bacb2d..27bef49218 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -149,6 +149,7 @@ void i2c_generic_fill_ssdt(const struct device *dev, /* Rotation Matrix */ if (config->has_rotation_matrix) { acpigen_write_method("ROTM", 0); + acpigen_write_name("RBUF"); acpigen_write_package(3); for (int i = 0; i < 3; i++) { @@ -160,6 +161,8 @@ void i2c_generic_fill_ssdt(const struct device *dev, acpigen_write_string(matrix_row); } + acpigen_pop_len(); + acpigen_write_return_namestr("RBUF"); acpigen_pop_len(); acpigen_pop_len(); -- cgit v1.2.3