From 45be5b3b4e284f6e22cc81b884180f59898a43ed Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Fri, 25 Aug 2023 11:50:25 +0200 Subject: device/device.h: Fix outdated comment LAPIC devices in devicetree is not possible any longer since commit 3eba665 "util/sconfig: Remove lapic devices from devicetree parsers". TEST=intel/archercity CRB Signed-off-by: Arthur Heymans Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78329 Tested-by: build bot (Jenkins) Reviewed-by: Shuo Liu Reviewed-by: Lean Sheng Tan --- src/include/device/device.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/include/device/device.h b/src/include/device/device.h index 50307e6d90..752e1c02aa 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -229,14 +229,7 @@ struct device *add_cpu_device(struct bus *cpu_bus, unsigned int apic_id, void mp_init_cpus(DEVTREE_CONST struct bus *cpu_bus); static inline void mp_cpu_bus_init(struct device *dev) { - /* - * When no LAPIC device is specified in the devicetree inside the CPU cluster device, - * neither a LAPIC device nor the link/bus between the CPU cluster and the LAPIC device - * will be present in the static device tree and the link_list struct element of the - * CPU cluster device will be NULL. In this case add one link, so that the - * alloc_find_dev calls in init_bsp and allocate_cpu_devices will be able to add a - * LAPIC device for the BSP and the APs on this link/bus. - */ + /* Make sure the cpu cluster has a downstream bus for LAPICs to be allocated. */ if (!dev->link_list) add_more_links(dev, 1); -- cgit v1.2.3