From 3ecc77722c9f7e857b9c034d4e01ee5f298b6c1f Mon Sep 17 00:00:00 2001 From: John Su Date: Fri, 25 Mar 2022 10:37:52 +0800 Subject: device/pciexp_device: Set resources for pciexp_hotplug_dummy_ops Without setting the set_resources field for pciexp_hotplug_dummy_ops, we will get an error during pciexp_hotplug_dummy. [ERROR] NONE missing set_resources Because the set_resources field is considered mandatory, explicitly set it as no-op noop_set_resources. BUG=b:220639445 TEST=emerge-brya coreboot Signed-off-by: John Su Change-Id: Ifee7479c69cf16025dbd4e3924056ed7f8e253cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/63101 Reviewed-by: Eric Lai Reviewed-by: Tim Wawrzynczak Tested-by: build bot (Jenkins) --- src/device/pciexp_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c52530196d..36143402ab 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -585,6 +585,7 @@ static void pciexp_hotplug_dummy_read_resources(struct device *dev) static struct device_operations pciexp_hotplug_dummy_ops = { .read_resources = pciexp_hotplug_dummy_read_resources, + .set_resources = noop_set_resources, }; void pciexp_hotplug_scan_bridge(struct device *dev) -- cgit v1.2.3