From 3b0f5426af8288bb039922405122282532cfa422 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Fri, 28 Jul 2017 17:34:49 +0200 Subject: ec/lenovo/pmh7: Dump revision and ID Dump PMH7 revision and ID for diagnostic purposes. Tested on Lenovo T430: PMH7: ID 05 Revision 12 Change-Id: I60d15a8f740aeb974a79b27507e974a730cec174 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/20807 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans Reviewed-by: Alexander Couzens --- src/ec/lenovo/pmh7/pmh7.c | 4 ++++ src/ec/lenovo/pmh7/pmh7.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c index b2c3c08697..c9756795a0 100644 --- a/src/ec/lenovo/pmh7/pmh7.c +++ b/src/ec/lenovo/pmh7/pmh7.c @@ -121,6 +121,10 @@ static void enable_dev(struct device *dev) if (get_option(&val, "trackpoint") != CB_SUCCESS) val = 1; pmh7_trackpoint_enable(val); + + printk(BIOS_INFO, "PMH7: ID %02x Revision %02x\n", + pmh7_register_read(EC_LENOVO_PMH7_REG_ID), + pmh7_register_read(EC_LENOVO_PMH7_REG_REV)); } struct chip_operations ec_lenovo_pmh7_ops = { diff --git a/src/ec/lenovo/pmh7/pmh7.h b/src/ec/lenovo/pmh7/pmh7.h index 772312cba4..d486ceb041 100644 --- a/src/ec/lenovo/pmh7/pmh7.h +++ b/src/ec/lenovo/pmh7/pmh7.h @@ -22,6 +22,9 @@ #define EC_LENOVO_PMH7_ADDR (EC_LENOVO_PMH7_BASE + 0x0c) #define EC_LENOVO_PMH7_DATA (EC_LENOVO_PMH7_BASE + 0x0e) +#define EC_LENOVO_PMH7_REG_ID 0xc2 +#define EC_LENOVO_PMH7_REG_REV 0xc3 + void pmh7_register_set_bit(int reg, int bit); void pmh7_register_clear_bit(int reg, int bit); char pmh7_register_read(int reg); -- cgit v1.2.3