From 37e160efb5973ebe7b8b3f5e445d3bdf33c35dd5 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 20 Oct 2021 23:43:12 +0200 Subject: soc/intel/baytrail: use mp_cpu_bus_init Implement mp_init_cpus and use mp_cpu_bus_init as init function in cpu_bus_ops. Signed-off-by: Felix Held Change-Id: I057ae8d95bdc510e9e7afb144b692531107fa45d Reviewed-on: https://review.coreboot.org/c/coreboot/+/58506 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/soc/intel/baytrail/chip.c | 2 +- src/soc/intel/baytrail/cpu.c | 5 ++--- src/soc/intel/baytrail/include/soc/ramstage.h | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/soc/intel/baytrail/chip.c b/src/soc/intel/baytrail/chip.c index c7eb149020..1f72dc4490 100644 --- a/src/soc/intel/baytrail/chip.c +++ b/src/soc/intel/baytrail/chip.c @@ -17,7 +17,7 @@ static struct device_operations pci_domain_ops = { static struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, - .init = baytrail_init_cpus, + .init = mp_cpu_bus_init, }; static void enable_dev(struct device *dev) diff --git a/src/soc/intel/baytrail/cpu.c b/src/soc/intel/baytrail/cpu.c index 98400d1a1a..1dbc3d7751 100644 --- a/src/soc/intel/baytrail/cpu.c +++ b/src/soc/intel/baytrail/cpu.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -193,10 +194,8 @@ static const struct mp_ops mp_ops = { .post_mp_init = post_mp_init, }; -void baytrail_init_cpus(struct device *dev) +void mp_init_cpus(struct bus *cpu_bus) { - struct bus *cpu_bus = dev->link_list; - /* TODO: Handle mp_init_with_smm failure? */ mp_init_with_smm(cpu_bus, &mp_ops); } diff --git a/src/soc/intel/baytrail/include/soc/ramstage.h b/src/soc/intel/baytrail/include/soc/ramstage.h index 51189cfd46..8b4727c260 100644 --- a/src/soc/intel/baytrail/include/soc/ramstage.h +++ b/src/soc/intel/baytrail/include/soc/ramstage.h @@ -9,7 +9,6 @@ /* The baytrail_init_pre_device() function is called prior to device * initialization, but it's after console and cbmem has been reinitialized. */ void baytrail_init_pre_device(struct soc_intel_baytrail_config *config); -void baytrail_init_cpus(struct device *dev); void southcluster_enable_dev(struct device *dev); /* The baytrail_run_reference_code() function is provided by either * native refcode or the ChromeBook refcode wrapper */ -- cgit v1.2.3