From 37c332782a90c2a3f1543ece585ac305d6c610de Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Mon, 1 Mar 2021 08:24:52 -0700 Subject: mb/google/brya: Fix a few mistakes in brya0 overridetree 1) Both SAR sensors had a UID of `2`, making them indistinguishable 2) No `device` underneath max98357a `chip` Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Signed-off-by: Tim Wawrzynczak Reviewed-on: https://review.coreboot.org/c/coreboot/+/51145 Reviewed-by: Angel Pons Reviewed-by: EricR Lai Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/Kconfig | 1 + src/mainboard/google/brya/variants/brya0/overridetree.cb | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index e4f7258ef6..d0391af8cb 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -3,6 +3,7 @@ config BOARD_GOOGLE_BASEBOARD_BRYA select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID + select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_SX9324 select DRIVERS_SPI_ACPI select DRIVERS_WIFI_GENERIC diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 030d19e6fa..b70f156b51 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -73,7 +73,7 @@ chip soc/intel/alderlake register "desc" = ""SAR1 Proximity Sensor"" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H19_IRQ)" register "speed" = "I2C_SPEED_FAST" - register "uid" = "2" + register "uid" = "1" register "reg_gnrl_ctrl0" = "0x16" register "reg_gnrl_ctrl1" = "0x21" register "reg_afe_ctrl0" = "0x00" @@ -183,6 +183,7 @@ chip soc/intel/alderlake register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A11)" register "sdmode_delay" = "5" + device generic 0 on end end end device ref gspi1 on -- cgit v1.2.3