From 35efba2bc06921d68ae4a345ab611f5d3ac3d5d1 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 28 May 2021 15:54:21 +0200 Subject: acpi: drop unused parameter from acpi_soc_fill_bert Signed-off-by: Felix Held Change-Id: Ic354824468f016a7857c6990024ae87db6fd00bf Reviewed-on: https://review.coreboot.org/c/coreboot/+/55052 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Lance Zhao --- src/acpi/acpi.c | 4 ++-- src/include/acpi/acpi.h | 2 +- src/soc/intel/common/block/acpi/acpi_bert.c | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 0874e6e21f..185825bb5f 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1565,7 +1565,7 @@ bool __weak acpi_is_boot_error_src_present(void) return false; } -__weak void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length) {} +__weak void acpi_soc_fill_bert(void **region, size_t *length) {} unsigned long __weak fw_cfg_acpi_tables(unsigned long start) { @@ -1815,7 +1815,7 @@ unsigned long write_acpi_tables(unsigned long start) size_t size; printk(BIOS_DEBUG, "ACPI: * BERT\n"); bert = (acpi_bert_t *) current; - acpi_soc_fill_bert(bert, ®ion, &size); + acpi_soc_fill_bert(®ion, &size); acpi_write_bert(bert, (uintptr_t)region, size); if (bert->header.length >= sizeof(acpi_bert_t)) { current += bert->header.length; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index d5e933bce5..dd00c405db 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1342,7 +1342,7 @@ unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t /* For crashlog. */ bool acpi_is_boot_error_src_present(void); -void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length); +void acpi_soc_fill_bert(void **region, size_t *length); /* For ACPI S3 support. */ void __noreturn acpi_resume(void *wake_vec); diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c index d090dfd2cf..f94026d9bc 100644 --- a/src/soc/intel/common/block/acpi/acpi_bert.c +++ b/src/soc/intel/common/block/acpi/acpi_bert.c @@ -8,9 +8,7 @@ #include -void acpi_soc_fill_bert(acpi_bert_t *bert, - void **region, - size_t *length) +void acpi_soc_fill_bert(void **region, size_t *length) { acpi_generic_error_status_t *status = NULL; size_t cpu_record_size, pmc_record_size; -- cgit v1.2.3