From 35348fc0058c514653228f8e53d30181cff794d1 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Tue, 31 Oct 2023 11:21:09 +0530 Subject: mb/google/rex: Avoid hang for pre-prod SoC by setting SAGV_POINTS_0_1_2 Intel has identified an idle hang issue on pre-prod silicon that will not be fixed or root-caused. To avoid the issue, this commit sets SaGvWpMask to SAGV_POINTS_0_1_2 in the devicetree. Note: This change will affect system power. BUG=b:287170545 TEST=Able to idle for more than 5+ hours without any hang on google/screebo. Change-Id: Id0b8db0076d983d336c3bec6d6c33614c69964d1 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/78794 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb | 2 ++ src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb index 0835ded2f2..7358eeb80c 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb @@ -52,6 +52,8 @@ chip soc/intel/meteorlake register "cnvi_bt_core" = "true" register "sagv" = "SAGV_ENABLED" + # TODO(b/287170545): workaround avoid DUT random hang + register "sagv_wp_bitmap" = "SAGV_POINTS_0_1_2" register "sagv_freq_mhz[0]" = "3200" register "sagv_gear[0]" = "4" diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb index 5894fe637a..625a36b315 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb @@ -49,6 +49,8 @@ chip soc/intel/meteorlake register "cnvi_bt_core" = "true" register "sagv" = "SAGV_ENABLED" + # TODO(b/287170545): workaround avoid DUT random hang + register "sagv_wp_bitmap" = "SAGV_POINTS_0_1_2" register "sagv_freq_mhz[0]" = "3200" register "sagv_gear[0]" = "4" -- cgit v1.2.3