From 31fdefe5842b7b6f77f341b65cb7851c72fc8516 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 29 Jan 2021 22:33:17 +0100 Subject: soc/amd/stoneyridge/psp: fix check of MSR_PSP_ADDR contents TEST=Checked documentation, but not verified on hardware. Signed-off-by: Felix Held Change-Id: I06399ac9cb9c90701dbcba71cbc808a0d7e6ea0d Reviewed-on: https://review.coreboot.org/c/coreboot/+/50150 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Angel Pons --- src/soc/amd/stoneyridge/psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/stoneyridge/psp.c b/src/soc/amd/stoneyridge/psp.c index a7fead73dc..69db08dfc3 100644 --- a/src/soc/amd/stoneyridge/psp.c +++ b/src/soc/amd/stoneyridge/psp.c @@ -45,7 +45,7 @@ void *soc_get_mbox_address(void) * the MSR instead. */ if (pci_read_config32(SOC_PSP_DEV, PSP_BAR_ENABLES) & BAR3HIDE) { psp_mmio = rdmsr(MSR_PSP_ADDR).lo; - if (psp_mmio == 0xffffffff) { + if (!psp_mmio) { printk(BIOS_WARNING, "PSP: BAR hidden, MSR_PSP_ADDR uninitialized\n"); return 0; } -- cgit v1.2.3