From 2fca0261f1c08b3f2f09b3fbddd981badb577125 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 10 May 2023 13:32:29 -0600 Subject: mb/amd/birman: Don't select the console UART, default to y Things with prompts should not use selects, but should instead default to y. If there's a reason they need to be selected, they should be able to be hidden when they're selected. This isn't one of those cases where a select is needed, so set the default to y instead. Signed-off-by: Martin Roth Change-Id: If6de339c3a1ceb3cd71008402bba49b5efc4af3f Reviewed-on: https://review.coreboot.org/c/coreboot/+/75131 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Fred Reitberger Reviewed-by: Paul Menzel --- src/mainboard/amd/birman/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mainboard/amd/birman/Kconfig b/src/mainboard/amd/birman/Kconfig index 5d297dabc2..d7fd1a5a4c 100644 --- a/src/mainboard/amd/birman/Kconfig +++ b/src/mainboard/amd/birman/Kconfig @@ -7,7 +7,6 @@ config BOARD_SPECIFIC_OPTIONS select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM select EC_ACPI select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD - select AMD_SOC_CONSOLE_UART if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD select DRIVERS_PCIE_RTD3_DEVICE select MAINBOARD_HAS_CHROMEOS select PCIEXP_ASPM @@ -48,6 +47,9 @@ config BIRMAN_MCHP_SIG_FILE The first 4 bytes form a pointer (with CRC) to where the EC firmware is located +config AMD_SOC_CONSOLE_UART + default y if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD + config BIRMAN_MCHP_FW_FILE string "Microchip EC firmware file" depends on BIRMAN_HAVE_MCHP_FW -- cgit v1.2.3