From 2d1e0eb8a77ff4eb08b3ccd059d3eee3bef2201d Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 3 Aug 2017 10:55:01 -0600 Subject: payloads/coreinfo: Free buffer before returning Fixes coverity issue 1373370 - Resource leak Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/20876 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Werner Zeh --- payloads/coreinfo/timestamps_module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/payloads/coreinfo/timestamps_module.c b/payloads/coreinfo/timestamps_module.c index 020fcc6971..fda5a9608a 100644 --- a/payloads/coreinfo/timestamps_module.c +++ b/payloads/coreinfo/timestamps_module.c @@ -210,8 +210,10 @@ static int timestamps_module_init(void) g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0); g_buf = malloc(chars_count); - if (!g_buf) + if (!g_buf) { + free(buffer); return -3; + } if (sanitize_buffer_for_display(buffer, buff_cur + 1, g_buf, chars_count, SCREEN_X) < 0) { -- cgit v1.2.3