From 2bca750f1085cfb46cb3efb554e889234ad61312 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Thu, 27 Jun 2024 23:09:08 +0200 Subject: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings Configuring USB2_PORT_EMPTY is equal to just not setting it. So remove it to clean up a bit. Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/83246 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb | 1 - src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb | 4 ---- 2 files changed, 5 deletions(-) diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index fede521d22..9c5fa6da32 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -181,7 +181,6 @@ chip soc/intel/tigerlake device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC0), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC3), // M.2 Bluetooth [3] = USB2_PORT_MID(OC0), // USB3/2 Type A port1 [4] = USB2_PORT_MID(OC0), // Type-C Port2 diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 23ccfb96af..578eb98a3a 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -189,14 +189,10 @@ chip soc/intel/tigerlake device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC3), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC0), // M.2 Bluetooth, USB3/2 Type A Port1 [3] = USB2_PORT_MID(OC3), // USB3/2 Type A Port 1 [4] = USB2_PORT_MID(OC3), // Type-C Port2 [5] = USB2_PORT_MID(OC3), // Type-C Port3 / MECC - [6] = USB2_PORT_EMPTY, // Not used - [7] = USB2_PORT_EMPTY, // Not used - [8] = USB2_PORT_EMPTY, // Not used [9] = USB2_PORT_MID(OC3), // CNVi/BT }" -- cgit v1.2.3