From 2609eaaa8fc6c6d6b0285ee9be571164c5821270 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Wed, 18 Nov 2020 13:57:35 +0100 Subject: src/drivers/i2c/rx6110sa: Omit _HID temporarily The current HID "RX6110SA" does not comply with the ACPI spec in terms of the naming convention where the first three caracters should be a vendor ID and the last 4 characters should be a device ID. For now there is a vendor ID for Epson (SEC) but there is none for this particular RTC. In order to avoid the reporting of a non ACPI-compliant HID it will be dropped completely for now. Once Epson has assigned a valid HID for this RTC, this valid HID will be used here instead. Change-Id: Ib77ffad084c25f60f79ec7d503f14731b1ebe9e2 Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/coreboot/+/47706 Reviewed-by: Nico Huber Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/drivers/i2c/rx6110sa/rx6110sa.c | 1 - src/drivers/i2c/rx6110sa/rx6110sa.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index 2b8b9b28f0..210444ebc4 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -198,7 +198,6 @@ static void rx6110sa_fill_ssdt(const struct device *dev) /* Device */ acpigen_write_scope(scope); acpigen_write_device(acpi_device_name(dev)); - acpigen_write_name_string("_HID", RX6110SA_HID_NAME); acpigen_write_name_string("_DDN", RX6110SA_HID_DESC); acpigen_write_STA(acpi_device_status(dev)); diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h index 557a7489a1..fc0109db2a 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.h +++ b/src/drivers/i2c/rx6110sa/rx6110sa.h @@ -4,7 +4,6 @@ #define _I2C_RX6110SA_H_ #define RX6110SA_ACPI_NAME "ERX6" -#define RX6110SA_HID_NAME "RX6110SA" #define RX6110SA_HID_DESC "Real Time Clock" /* Register layout */ -- cgit v1.2.3