From 21666e4611322f51fc9c291701f1cd89a6497f43 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 7 Mar 2021 13:09:47 +0100 Subject: soc/intel/fast_spi/Makefile: Fix exit of 16mib-check recipe Currently, if everything worked fine, `$fail` will be unset, leading to the following `if` statement: if [ -eq 1 ] Resulting in the error message: /bin/sh: line 9: [: -eq: unary operator expected Fix this by removing the whole `if`, we can just use `exit`. Change-Id: I1bc7508d2a45a2bec07ef46b9c5d9d0b740fbc74 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/51324 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Furquan Shaikh --- src/soc/intel/common/block/fast_spi/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/common/block/fast_spi/Makefile.inc b/src/soc/intel/common/block/fast_spi/Makefile.inc index 2ee64eb0d6..75596de75b 100644 --- a/src/soc/intel/common/block/fast_spi/Makefile.inc +++ b/src/soc/intel/common/block/fast_spi/Makefile.inc @@ -44,7 +44,7 @@ $(call add_intermediate, check-fmap-16mib-crossing, $(obj)/fmap_config.h) end=$$((start+size-1)); \ if [ $$start -lt 16777216 ] && [ $$end -ge 16777216 ]; then echo "ERROR:" $$x "crosses 16MiB boundary"; fail=1; break; fi; \ done; \ - if [ $$fail -eq 1 ]; then false; fi + exit $$fail CBFSTOOL_ADD_CMD_OPTIONS += --ext-win-base $(CONFIG_EXT_BIOS_WIN_BASE) --ext-win-size $(CONFIG_EXT_BIOS_WIN_SIZE) -- cgit v1.2.3