From 1f572b9276ae3d20b37dbdb52e466ecfe5bbe06b Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Sun, 10 May 2020 23:00:16 -0400 Subject: superio/nuvoton/nct6779d: Open some LDN config registers The porting of Asus P8Z77-M mainboard required changing certain Super I/O configuration registers that were ignored in devicetree.cb because they aren't listed as resources. Add the declaration so they can be changed. This change is nowhere near enough as the current structure is insufficient to allow changing configuration registers in the 0xE? range, which this board also needs. TEST=Changes to config regs 0xf4, 0xf5 in LDN 9 are reflected when inspected using superiotool -d. Change-Id: Ia31aafda3fa9423d516b5d839ef5265e8e8ccdd2 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/41226 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Felix Held --- src/superio/nuvoton/nct6779d/superio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/superio/nuvoton/nct6779d/superio.c b/src/superio/nuvoton/nct6779d/superio.c index 843857c7f3..ef50aa6c05 100644 --- a/src/superio/nuvoton/nct6779d/superio.c +++ b/src/superio/nuvoton/nct6779d/superio.c @@ -37,8 +37,8 @@ static struct pnp_info pnp_dev_info[] = { { NULL, NCT6779D_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x0fff, 0x0fff, }, { NULL, NCT6779D_CIR, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, - { NULL, NCT6779D_ACPI}, - { NULL, NCT6779D_HWM_FPLED, PNP_IO0 | PNP_IO1 | PNP_IRQ0, + { NULL, NCT6779D_ACPI, PNP_MSC2,}, + { NULL, NCT6779D_HWM_FPLED, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_MSC0, 0x0ffe, 0x0ffe, }, { NULL, NCT6779D_WDT1}, { NULL, NCT6779D_CIRWKUP, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, @@ -51,8 +51,8 @@ static struct pnp_info pnp_dev_info[] = { { NULL, NCT6779D_GPIO2}, { NULL, NCT6779D_GPIO3}, { NULL, NCT6779D_GPIO4}, - { NULL, NCT6779D_GPIO5}, - { NULL, NCT6779D_GPIO6}, + { NULL, NCT6779D_GPIO5, PNP_MSC4 | PNP_MSC5}, + { NULL, NCT6779D_GPIO6, PNP_MSC4 | PNP_MSC5}, { NULL, NCT6779D_GPIO7}, { NULL, NCT6779D_GPIO8}, }; -- cgit v1.2.3