From 1dff52556ebf0d3c4e6a64a27b233353bd32e89f Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Tue, 4 Apr 2023 14:27:54 +0200 Subject: mb/siemens/mc_ehl4: Switch RTC type and connection This mainboard has the RTC RV-3028-C7 connected to the I2C1. TEST: - Console Log shows no errors for RV-3028-C7 during I2C1 init - Finalize device for I2C 00:52 shows correct date and time Change-Id: I1b4115d7844a0c218fdf92cb1af2da5a95eb4337 Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/c/coreboot/+/74652 Reviewed-by: Jan Samek Reviewed-by: Paul Menzel Reviewed-by: Werner Zeh Tested-by: build bot (Jenkins) --- .../siemens/mc_ehl/variants/mc_ehl4/Kconfig | 2 +- .../siemens/mc_ehl/variants/mc_ehl4/devicetree.cb | 33 ++++++++++------------ 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/Kconfig index 21789d7b8e..8a40072939 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/Kconfig +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/Kconfig @@ -2,7 +2,7 @@ if BOARD_SIEMENS_MC_EHL4 config BOARD_SPECIFIC_OPTIONS def_bool y - select DRIVERS_I2C_RX6110SA + select DRIVERS_I2C_RV3028C7 select DRIVER_INTEL_I210 select INTEL_LPSS_UART_FOR_CONSOLE select NC_FPGA_POST_CODE diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb index 5cc496f4b4..0d1ae7115e 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb @@ -148,7 +148,20 @@ chip soc/intel/elkhartlake device pci 14.0 on end # USB3.1 xHCI device pci 15.0 off end # I2C0 - device pci 15.1 on end # I2C1 + device pci 15.1 on # I2C1 + # Enable external RTC chip + chip drivers/i2c/rv3028c7 + register "bus_speed" = "I2C_SPEED_STANDARD" + register "set_user_date" = "1" + register "user_year" = "04" + register "user_month" = "07" + register "user_day" = "01" + register "user_weekday" = "4" + register "bckup_sw_mode" = "BACKUP_SW_LEVEL" + register "cap_charge" = "CHARGE_OFF" + device i2c 0x52 on end # RTC RV3028-C7 + end + end device pci 16.0 hidden end # Management Engine Interface 1 @@ -168,25 +181,9 @@ chip soc/intel/elkhartlake device pci 1e.0 on end # UART0 device pci 1e.1 on end # UART1 - device pci 1f.0 on end # eSPI Interface device pci 1f.2 hidden end # Power Management Controller - device pci 1f.4 on # SMBus - # Enable external RTC chip - chip drivers/i2c/rx6110sa - register "bus_speed" = "I2C_SPEED_STANDARD" - register "pmon_sampling" = "PMON_SAMPL_256_MS" - register "bks_on" = "0" - register "bks_off" = "1" - register "iocut_en" = "1" - register "set_user_date" = "1" - register "user_year" = "04" - register "user_month" = "07" - register "user_day" = "01" - register "user_weekday" = "4" - device i2c 0x32 on end # RTC RX6110 SA - end - end + device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI (flash & TPM) end end -- cgit v1.2.3