From 1d260e65739e60cb0e3a72c38aded614ea4b193e Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 9 Sep 2019 13:55:42 +0530 Subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For CML & ICL, FSP requires at least heap = 0x10000 and stack = 0x20000. Refer to FSP integration guide to know the exact FSP requirement. BUG=b:140268415 TEST=Build and boot CML-Hatch and ICL. Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/35301 Reviewed-by: Kyösti Mälkki Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/drivers/intel/fsp2_0/Kconfig | 6 +++++- src/soc/intel/cannonlake/Kconfig | 9 +++++++++ src/soc/intel/icelake/Kconfig | 9 +++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index 541ec47b46..1e84dabbbe 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -154,8 +154,12 @@ config FSP_USES_CB_STACK config FSP_TEMP_RAM_SIZE hex - default 0x10000 depends on FSP_USES_CB_STACK + help + The amount of anticipated heap usage in CAR by FSP to setup HOB. + This configuration is applicable for FSP specification using shared + stack with coreboot/bootloader. + Sync this value with Platform FSP integration guide recommendation. config VERIFY_HOBS bool "Verify the FSP hand-off-blocks" diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index d949fffc79..fc3f2ac3c2 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -125,6 +125,15 @@ config DCACHE_BSP_STACK_SIZE The amount of anticipated stack usage in CAR by bootblock and other stages. +config FSP_TEMP_RAM_SIZE + hex + depends on FSP_USES_CB_STACK + default 0x10000 + help + The amount of anticipated heap usage in CAR by FSP. + Refer to Platform FSP integration guide document to know + the exact FSP requirement for Heap setup. + config IFD_CHIPSET string default "cnl" diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 1bd478c70e..05fe423fac 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -76,6 +76,15 @@ config DCACHE_BSP_STACK_SIZE The amount of anticipated stack usage in CAR by bootblock and other stages. +config FSP_TEMP_RAM_SIZE + hex + depends on FSP_USES_CB_STACK + default 0x10000 + help + The amount of anticipated heap usage in CAR by FSP. + Refer to Platform FSP integration guide document to know + the exact FSP requirement for Heap setup. + config IFD_CHIPSET string default "icl" -- cgit v1.2.3