From 19453ec7a63421e7dfe24e8ffec66aba16e7d177 Mon Sep 17 00:00:00 2001 From: Frank Chu Date: Fri, 8 Mar 2024 18:24:15 +0800 Subject: mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz Update touchpad and touchscreen I2C timing. - Data hold time: 300ns - 900ns BUG=b:328724191 BRANCH=firmware-nissa-15217.B TEST=Check wave form and met the spec. I2C1 (touchscreen) Hold time from 83.58ns to 413.87ns I2C5 (touchpad) Hold time from 95.93ns to 425.27ns Change-Id: I65fb1298f9e96ab0b63aba436f6a319f21b38925 Signed-off-by: Frank Chu Reviewed-on: https://review.coreboot.org/c/coreboot/+/81136 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth Reviewed-by: Eric Lai Reviewed-by: Matt DeVillier Reviewed-by: Shawn Ku --- src/mainboard/google/brya/variants/glassway/overridetree.cb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/variants/glassway/overridetree.cb b/src/mainboard/google/brya/variants/glassway/overridetree.cb index 8c779d75f2..29629d44fc 100644 --- a/src/mainboard/google/brya/variants/glassway/overridetree.cb +++ b/src/mainboard/google/brya/variants/glassway/overridetree.cb @@ -129,7 +129,7 @@ chip soc/intel/alderlake .speed = I2C_SPEED_FAST, .scl_lcnt = 157, .scl_hcnt = 79, - .sda_hold = 7, + .sda_hold = 40, } }, .i2c[2] = { @@ -156,7 +156,7 @@ chip soc/intel/alderlake .speed = I2C_SPEED_FAST, .scl_lcnt = 158, .scl_hcnt = 79, - .sda_hold = 7, + .sda_hold = 40, } }, }" -- cgit v1.2.3