From 1816649b9027a48f03217f9c2a91f90678fd9446 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 4 Nov 2014 20:47:23 -0600 Subject: arm64: secmon: direct non-BSP cpus to start before BSP The arch_run_on_all_cpus[_async]() APIs can run the BSP before the APs if the BSP's id is less than the APs' ids. Fix this by ensuring we run the necessary callback on all but self. BUG=chrome-os-partner:33532 BRANCH=None TEST=Booted spin table kernel. All CPUs are up. Change-Id: Ic9a466c3642595bad06cac83647de81873b8353e Signed-off-by: Patrick Georgi Original-Commit-Id: 575437354cc20eeac8015a0f7b0c9999ecb0deee Original-Change-Id: I87e944f870105dbde33b5460660c96c93c3cdf93 Original-Signed-off-by: Aaron Durbin Original-Reviewed-on: https://chromium-review.googlesource.com/227488 Original-Tested-by: David Riley Original-Reviewed-by: Tom Warren Original-Reviewed-by: Furquan Shaikh Reviewed-on: http://review.coreboot.org/9392 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/arch/arm64/armv8/secmon/secmon_init.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/arch/arm64/armv8/secmon/secmon_init.c b/src/arch/arm64/armv8/secmon/secmon_init.c index 9097a08b36..2ec2f136f7 100644 --- a/src/arch/arm64/armv8/secmon/secmon_init.c +++ b/src/arch/arm64/armv8/secmon/secmon_init.c @@ -70,7 +70,10 @@ static void secmon_init(struct secmon_params *params, int bsp) smc_init(); psci_init(); - arch_run_on_all_cpus_async(&action); + /* Make sure all non-BSP CPUs take action before the BSP. */ + arch_run_on_all_cpus_but_self_async(&action); + /* Turn on BSP. */ + start_up_cpu(NULL); printk(BIOS_ERR, "CPU turn on failed for BSP.\n"); while (1) -- cgit v1.2.3