From 0d20e3c72050cb8a33b2c076a8a64de9590d0421 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 1 Apr 2023 01:26:39 +0200 Subject: Makefile.inc: introduce all_x86 target For compilation units that should be built for all stages that run on the x86 cores in a newer AMD SoC, but can't be built for verstage on PSP which is an ARM core, the 'all' target can't be used, since that would result in the compilation unit also being added to the verstage target in the verstage on PSP case. In order to not need to add a compilation unit to the 'bootblock', 'verstage_x86', 'romstage', and 'ramstage' targets in separate lines in the Makefile, introduce the 'all_x86' target that adds a file to 'bootblock', 'verstage_x86', 'romstage', 'postcar', and 'ramstage'. The compilation units also need to be added to the 'postcar' stage which is only present on the pre-Zen SoCs to be able to also use the 'all_x86' target in common AMD code that is also used in those pre-Zen SoCs. Signed-off-by: Felix Held Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e Reviewed-on: https://review.coreboot.org/c/coreboot/+/74150 Reviewed-by: Fred Reitberger Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Arthur Heymans --- Makefile.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.inc b/Makefile.inc index d2d3f88607..6901ef490a 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -107,6 +107,9 @@ classes-y := ramstage romstage bootblock decompressor postcar smm smmstub cpu_mi $(call add-special-class,all) all-handler = $(foreach class,bootblock verstage romstage postcar ramstage,$(eval $(class)-y += $(2))) +$(call add-special-class,all_x86) +all_x86-handler = $(foreach class,bootblock verstage_x86 romstage postcar ramstage,$(eval $(class)-y += $(2))) + $(call add-special-class,verstage_x86) ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y) verstage_x86-handler = $(eval verstage-y += $(2)) -- cgit v1.2.3