From 04c497a6ba6ba0219da5c4a32570fa46a0b239b9 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 3 Nov 2021 16:30:10 +0100 Subject: cpu/intel: Use unsigned types in `get_cpu_count()` Change-Id: Id95e45a3eba384a61c02016b7663ec71c3ae1865 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/58917 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/cpu/intel/haswell/haswell_init.c | 4 ++-- src/cpu/intel/model_1067x/mp_init.c | 2 +- src/cpu/intel/model_2065x/model_2065x_init.c | 4 ++-- src/cpu/intel/model_206ax/model_206ax_init.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c index 2ab77b3044..d4f3587766 100644 --- a/src/cpu/intel/haswell/haswell_init.c +++ b/src/cpu/intel/haswell/haswell_init.c @@ -588,8 +588,8 @@ static void pre_mp_init(void) static int get_cpu_count(void) { msr_t msr; - int num_threads; - int num_cores; + unsigned int num_threads; + unsigned int num_cores; msr = rdmsr(MSR_CORE_THREAD_COUNT); num_threads = (msr.lo >> 0) & 0xffff; diff --git a/src/cpu/intel/model_1067x/mp_init.c b/src/cpu/intel/model_1067x/mp_init.c index 9a1fc42d3e..bc53214310 100644 --- a/src/cpu/intel/model_1067x/mp_init.c +++ b/src/cpu/intel/model_1067x/mp_init.c @@ -23,7 +23,7 @@ static void pre_mp_init(void) static int get_cpu_count(void) { const struct cpuid_result cpuid1 = cpuid(1); - const char cores = (cpuid1.ebx >> 16) & 0xf; + const unsigned int cores = (cpuid1.ebx >> 16) & 0xf; printk(BIOS_DEBUG, "CPU has %u cores.\n", cores); diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c index 30519c0256..e77f9aaa75 100644 --- a/src/cpu/intel/model_2065x/model_2065x_init.c +++ b/src/cpu/intel/model_2065x/model_2065x_init.c @@ -124,8 +124,8 @@ static void pre_mp_init(void) static int get_cpu_count(void) { msr_t msr; - int num_threads; - int num_cores; + unsigned int num_threads; + unsigned int num_cores; msr = rdmsr(MSR_CORE_THREAD_COUNT); num_threads = (msr.lo >> 0) & 0xffff; diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c index d240f53761..9de6b38198 100644 --- a/src/cpu/intel/model_206ax/model_206ax_init.c +++ b/src/cpu/intel/model_206ax/model_206ax_init.c @@ -380,8 +380,8 @@ static void pre_mp_init(void) static int get_cpu_count(void) { msr_t msr; - int num_threads; - int num_cores; + unsigned int num_threads; + unsigned int num_cores; msr = rdmsr(MSR_CORE_THREAD_COUNT); num_threads = (msr.lo >> 0) & 0xffff; -- cgit v1.2.3