From 0427788e2449abb1ebc318dc5e93d6aa5cc0aa6d Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Tue, 15 Nov 2022 18:11:36 +0530 Subject: mb/google/rex: Add `disable_gpio_export_in_crs` for rex None of the touchscreens (over I2C) used in the rex program requires exporting GPIOs in the ACPI _CRS method. This can cause i2c devices to malfunction or cause timing sequence violations if ACPI exports a PowerResource for the device that uses GPIOs that are also exported in _CRS. BUG=none TEST=Able to build and boot Google, Rex platform. Without this patch: [ERROR] I2C: 00:10: Exposing GPIOs in Power Resource and _CRS With this patch: None Signed-off-by: Subrata Banik Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b Reviewed-on: https://review.coreboot.org/c/coreboot/+/69612 Reviewed-by: Ivy Jian Reviewed-by: Kapil Porwal Reviewed-by: Sridhar Siricilla Tested-by: build bot (Jenkins) --- src/mainboard/google/rex/variants/rex0/overridetree.cb | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index a7f5a95c32..f3b0fab35a 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -357,6 +357,7 @@ chip soc/intel/meteorlake register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end -- cgit v1.2.3