From 038757d2d028dedce28923a7bef3100a870b3706 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 29 May 2020 13:46:09 -0700 Subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt. In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs. Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:E Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0. Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused). Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/coreboot/+/41880 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc | 6 ++++++ .../google/dedede/variants/waddledoo/memory/dram_id.generated.txt | 3 +++ .../google/dedede/variants/waddledoo/memory/mem_list_variant.txt | 2 ++ 3 files changed, 11 insertions(+) create mode 100644 src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc create mode 100644 src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt create mode 100644 src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc new file mode 100644 index 0000000000..8552e95b45 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc @@ -0,0 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-7.hex # ID = 0(0b0000) Parts = NT6AP256T32AV-J2 +SPD_SOURCES += spd-1.hex # ID = 1(0b0001) Parts = MT53E512M32D2NP-046 WT:E diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt new file mode 100644 index 0000000000..3c613288d2 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +NT6AP256T32AV-J2 0 (0000) +MT53E512M32D2NP-046 WT:E 1 (0001) diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt new file mode 100644 index 0000000000..8d043d7b2c --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +NT6AP256T32AV-J2 +MT53E512M32D2NP-046 WT:E -- cgit v1.2.3