summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/butterfly/chromeos.c16
-rw-r--r--src/mainboard/google/parrot/chromeos.c5
-rw-r--r--src/mainboard/google/stout/chromeos.c11
3 files changed, 16 insertions, 16 deletions
diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c
index a7d56aee4a..fb249d4def 100644
--- a/src/mainboard/google/butterfly/chromeos.c
+++ b/src/mainboard/google/butterfly/chromeos.c
@@ -48,6 +48,15 @@ int get_recovery_mode_switch(void)
return 0;
}
+bool mainboard_ec_running_ro(void)
+{
+ // TODO: MLR
+ // The firmware read/write status is a "virtual" switch and
+ // will be handled elsewhere. Until then hard-code to
+ // read/write instead of read-only for developer mode.
+ return false;
+}
+
static const struct cros_gpio cros_gpios[] = {
CROS_GPIO_REC_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
CROS_GPIO_WP_AL(WP_GPIO, CROS_GPIO_DEVICE_NAME),
@@ -55,13 +64,6 @@ static const struct cros_gpio cros_gpios[] = {
void mainboard_chromeos_acpi_generate(void)
{
- // TODO: MLR
- // The firmware read/write status is a "virtual" switch and
- // will be handled elsewhere. Until then hard-code to
- // read/write instead of read-only for developer mode.
- if (CONFIG(CHROMEOS_NVS))
- chromeos_set_ecfw_rw();
-
chromeos_acpi_gpio_generate(cros_gpios, ARRAY_SIZE(cros_gpios));
}
diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c
index 2b361ac569..e0bc0b0f62 100644
--- a/src/mainboard/google/parrot/chromeos.c
+++ b/src/mainboard/google/parrot/chromeos.c
@@ -46,7 +46,7 @@ int get_recovery_mode_switch(void)
return !get_gpio(GPIO_REC_MODE);
}
-static int parrot_ec_running_ro(void)
+bool mainboard_ec_running_ro(void)
{
return get_recovery_mode_switch();
}
@@ -58,9 +58,6 @@ static const struct cros_gpio cros_gpios[] = {
void mainboard_chromeos_acpi_generate(void)
{
- if (CONFIG(CHROMEOS_NVS) && !parrot_ec_running_ro())
- chromeos_set_ecfw_rw();
-
chromeos_acpi_gpio_generate(cros_gpios, ARRAY_SIZE(cros_gpios));
}
diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c
index 964217e8f1..fcbbc8aee0 100644
--- a/src/mainboard/google/stout/chromeos.c
+++ b/src/mainboard/google/stout/chromeos.c
@@ -49,8 +49,7 @@ int get_lid_switch(void)
* The recovery-switch is virtual on Stout and is handled via the EC.
* Stout recovery mode is only valid if RTC_PWR_STS is set and the EC
* indicated the recovery keys were pressed. We use a global flag for
- * rec_mode to be used after RTC_POWER_STS has been cleared. This function
- * is complicated by romstage support, which can't use a global variable.
+ * rec_mode to be used after RTC_POWER_STS has been cleared.
* Note, rec_mode is the only time the EC is in RO mode, otherwise, RW.
*/
int get_recovery_mode_switch(void)
@@ -75,6 +74,11 @@ int get_recovery_mode_switch(void)
return ec_in_rec_mode;
}
+bool mainboard_ec_running_ro(void)
+{
+ return !!get_recovery_mode_switch();
+}
+
static const struct cros_gpio cros_gpios[] = {
CROS_GPIO_REC_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
CROS_GPIO_WP_AL(GPIO_SPI_WP, CROS_GPIO_DEVICE_NAME),
@@ -82,8 +86,5 @@ static const struct cros_gpio cros_gpios[] = {
void mainboard_chromeos_acpi_generate(void)
{
- if (CONFIG(CHROMEOS_NVS) && !get_recovery_mode_switch())
- chromeos_set_ecfw_rw();
-
chromeos_acpi_gpio_generate(cros_gpios, ARRAY_SIZE(cros_gpios));
}